Commit Graph

3527 Commits

Author SHA1 Message Date
Pavel Djundik
d2106f1782
Merge pull request #1896 from thelounge/xpaw/fix-push-error
Fix error not showing up in failed push subscription
2017-12-24 22:53:04 +02:00
Pavel Djundik
80c11f2bde Fix error not showing up in failed push subscription 2017-12-24 22:12:36 +02:00
Jérémie Astori
ff6d6e3e82
Merge pull request #1887 from thelounge/greenkeeper/eslint-4.14.0
Update eslint to the latest version 🚀
2017-12-24 14:53:01 -05:00
Jérémie Astori
12dd11bd10
Merge pull request #1889 from thelounge/astorije/fix-window-on-load
Display the correct window on page reload
2017-12-24 14:47:13 -05:00
Pavel Djundik
f81f083b24 Open and focus correct channel when clicking on push notifications
Affects all notifications sent via service workers

Fixes #1550
2017-12-24 16:06:23 +02:00
Jérémie Astori
7d49730bad
Merge pull request #1892 from thelounge/astorije/fix-slideout
Fix slideout not closing on mobile when hitting a footer icon
2017-12-24 02:59:36 -05:00
Jérémie Astori
7f165a7593
Fix slideout not closing on mobile when hitting a footer icon
Introduced by 9691df67e3 (diff-e5178f7b74fe45f2cfe1baf9aa1ef6faR347).
Seriously...
2017-12-24 02:51:58 -05:00
Jérémie Astori
d1c2f0df72
Display the correct window on page reload
This commit packs 2 fixes:

- Reloading the page while viewing the settings or help window would now send you to a channel window. This was broken when fixing an issue with the "Join a channel..." form
- Reloading the page while viewing the changelog would also send you to a channel window. This is because, on reload, the click emitted was restricted to sidebar and footer, while it had to be emitted from the help page. It is yet another aspect of our wonky window management and hopefully we can make this much more robust with a better overall solution.
2017-12-23 20:46:43 -05:00
greenkeeper[bot]
7dec39a499 chore(package): update eslint to version 4.14.0 2017-12-23 23:31:34 +00:00
Pavel Djundik
7c2422ee19
Merge pull request #1881 from thelounge/astorije/fix-join-channel-load
Fix join channel UI opening by itself
2017-12-23 23:17:21 +02:00
Jérémie Astori
32a95c4d75
Merge pull request #1327 from thelounge/xpaw/view-changelog
Changelog viewer and updater checker in the client
2017-12-23 16:13:29 -05:00
Pavel Djundik
c14c3b73d2
Merge pull request #1882 from thelounge/astorije/join-ui-message
Improve wording of join channel UI form restrictions
2017-12-23 21:10:02 +02:00
Jérémie Astori
4b34a093c9
Reduce changelog client cache to 1h since as there is also server caching now 2017-12-23 13:38:34 -05:00
Jérémie Astori
57c24704af
Cache changelog information on the server for 15 minutes 2017-12-23 13:37:33 -05:00
Jérémie Astori
0cbe0cb24e
Merge pull request #1884 from thelounge/xpaw/fix-1883
Fix #1883: message gaps when reconnecting
2017-12-23 13:10:17 -05:00
Pavel Djundik
18d135ca92
Merge pull request #1880 from thelounge/astorije/client-settings-tooltip
Rename "Client Settings" into "Settings" in tooltip + cleanup
2017-12-23 11:38:31 +02:00
Pavel Djundik
6377e0de66 Fix #1883: message gaps when reconnecting 2017-12-23 11:36:52 +02:00
Jérémie Astori
7fa30980aa
Improve wording of join channel UI form restrictions
This gives a more actionable message to the user if they do not enter a valid value.
2017-12-23 03:05:29 -05:00
Jérémie Astori
6c50fe72b9
Fix join channel UI opening by itself
Without this, `target` was matching all of the lobby link, the "Join a channel..." button, and the join form submit button. This change restricts to the first one.
2017-12-23 03:00:16 -05:00
Jérémie Astori
685951966b
Rename "Client Settings" into "Settings" in tooltip, cleanup 2017-12-22 22:53:56 -05:00
Jérémie Astori
9691df67e3
Improve UI of the About section and changelog viewer
- Keep consistent width between the Help page and Changelog (which is already different from other windows 😠)
- Add icons to the About links
- Make sure `li` elements (i.e. all the lists in changelogs) are consistent in size with rest of the client
- Display version and release notes link on the "About The Lounge" header line, smaller, pushed to the right
- Check new releases when opening the Help window in order to display it without having to open the release notes. Release notes are being fed to the Changelog page at that moment to avoid fetching twice.
- Re-check version/fetch release notes after 24h. Since The Lounge can now run 24/7, reconnect when losing the network, we have to assume an "always-on" usage.
- Change icon, animate background color when getting response from GitHub to avoid flashing.
- Combine click handlers with our wonderful window management. These were the same handler, even with similar checks (`target` exists, etc.), just in 2 different places. This is necessary for the next item.
- Combine "Open release notes" and "Go back to Help" button behaviors with window management handlers. The window management code is gross as ever, and is in desperate need of a refactor, but at least there is no duplicated code for the same behavior + history management. This fixes the "Next" history behavior (however reloading the app while viewing the notes does not load on the notes, but this is a bug for a different PR!).
- Added a rule in the history management thingy: if a link we want to add history handling to has an `id`, store that in the state
- Added a button to go back to the Help window
- Fixed links to releases
- Send user to the GitHub issues *list* instead of *new issue form* because if they do not have a GitHub account, they will be redirected to the login page, which is a rather unpleasant experience when you are already confused...
- Fixed a bug that would return data about a new release in `latest` even though it is already the `current`. It was showing the current version as "The Lounge v... is now available".
- Added https://user-images.githubusercontent.com to the CSP rule when prefetch storage is enabled, because that is where we have stored screenshots in the changelog so far. Meh (we can improve that later if we decide to have a dedicated place for screenshots).
- Fetch changelog info even in public mode because users in public mode can access the release notes. They do not see the result of the version checker however.
2017-12-22 22:46:11 -05:00
Jérémie Astori
cbe9a4e221
Support pre blocks in our style
We use this in our changelogs. Style for this is straight from Bootstrap 3 minus the border.
2017-12-22 22:04:41 -05:00
Pavel Djundik
df858a5aaf
Add changelog viewing and update checking 2017-12-22 16:26:12 -05:00
Jérémie Astori
5490235f4d
Merge pull request #1836 from MaxLeiter/join_channel
Join channel UI
2017-12-22 13:13:34 -05:00
Jérémie Astori
47f95c234d
Call the openForm function specifically when clicking on the context menu instead of relying on click handler
Not defining a `toggleForm` function has the advantage of "fixing" the fact that clicking "Join a channel..." from the context menu would close it when it was already open
2017-12-22 12:18:49 -05:00
Jérémie Astori
1063d7b1d6
Mark the channel field of "Join a channel" UI as required 2017-12-22 12:18:48 -05:00
Jérémie Astori
a03f894888
Change content of tooltip and button when opening/closing join channel form 2017-12-22 12:18:48 -05:00
Jérémie Astori
d2b0385431
Add a keyboard handler to close the join form when hitting "Escape" 2017-12-22 12:18:48 -05:00
Jérémie Astori
9ea3966140
Move the join channel form to its own component 2017-12-22 12:18:47 -05:00
Jérémie Astori
522bba694b
Use an ellipsis for change nick and join channel tooltips 2017-12-22 12:18:47 -05:00
Jérémie Astori
3307ced4d8
Remove background on close/join-channel sidebar buttons 2017-12-22 12:18:47 -05:00
Max Leiter
3fde87efbc
Add join channel UI via context menu or plus button next to lobbys 2017-12-22 12:18:46 -05:00
Al McKinlay
148628c49f
Merge pull request #1877 from thelounge/greenkeeper/copy-webpack-plugin-4.3.1
Update copy-webpack-plugin to the latest version 🚀
2017-12-22 13:18:08 +00:00
greenkeeper[bot]
5edc8914b9 chore(package): update copy-webpack-plugin to version 4.3.1 2017-12-22 12:40:39 +00:00
Pavel Djundik
18a9a82c26
Merge pull request #1876 from thelounge/xpaw/notequal-lobby
Use notEqual helper for close button
2017-12-22 13:57:43 +02:00
Pavel Djundik
aad9033d06
Use notEqual helper for close button 2017-12-22 12:30:23 +02:00
Pavel Djundik
06becc798f
Merge pull request #1874 from thelounge/astorije/handlebars-notEqual
Add a `notEqual` block helper for Handlebars and tests for `equal`
2017-12-22 12:28:15 +02:00
Al McKinlay
8004e051aa
Merge pull request #1833 from Cldfire/master
Remove lobby close button
2017-12-22 10:18:29 +00:00
Al McKinlay
8ac0586464
Merge pull request #1875 from MiniDigger/patch-1
Fix incorrect documentation url in default config
2017-12-22 10:17:49 +00:00
MiniDigger
9517360531
Fix incorrect documentation url in default config 2017-12-22 10:16:09 +01:00
Jérémie Astori
371c5bcac2
Add a notEqual block helper for Handlebars 2017-12-21 22:09:08 -05:00
Jérémie Astori
6d053d65e7
Add tests for the Handlebars helper equal 2017-12-21 20:09:12 -05:00
Jérémie Astori
8652ca6968
Merge pull request #1845 from thelounge/astorije/error-loading
Improve error page at loading time
2017-12-21 19:23:41 -05:00
Jérémie Astori
f975426c61
Rename the error handlers file at loading time 2017-12-21 18:23:54 -05:00
Jérémie Astori
84db8d8866
Wrap entire error loading script in anonymous function to avoid leaks 2017-12-21 18:23:52 -05:00
Jérémie Astori
0ffd4d60d9
Improve error page at loading
- Display the "Reload page" instantly and not after 5 seconds
- Remove stack trace, buggy anyway
- Wrap the error details so it does not expand beyond boundaries (scrollbar would not show up either)
- Do not show the slow-loading warning on error
- Make zeeoe details selectable instead of editable
- Label improvements
2017-12-21 18:22:53 -05:00
Jérémie Astori
da7481c23c
Merge pull request #1850 from thelounge/xpaw/whois-dl
Format whois as a definition list
2017-12-21 18:05:01 -05:00
Jérémie Astori
3f9a8d6066
Merge pull request #1871 from thelounge/astorije/focus-buttons
Add visual feedback on focused buttons, for example when tabbing to it
2017-12-21 16:56:02 -05:00
Jérémie Astori
98cab94f9b
Add visual feedback on focused buttons, for example when tabbing to it 2017-12-21 16:38:20 -05:00
Pavel Djundik
56b5a13abc
Merge pull request #1855 from MaxLeiter/primer-npm
Update to primer on npm
2017-12-21 16:41:54 +02:00