Guido Cella
298949bbc4
place child clients above fullscreen clients
...
When a child window of a fullscreen client is mapped, the fullscreen is
disabled, and if the previously fullscreen client is floating the child
window is rendered below it and cannot be seen, causing confusion,
though it is still focused and interactable.
Fix this by putting children of fullscreen clients in LyrFS instead of
LyrFloat, and by returning before the unset_fullscreen code is called
when they are mapped.
focusstack() now lets you switch focus from a fullscreen client to its
child windows, otherwise if you switch focus from the child window to
the fullscreen client you could not focus the child window again and the
fullscreen client would stay unresponsive.
Child clients are not reparented to LyrFloat after leaving fullscreen,
so you could spawn a child window, focus back the fullscreen client,
unfullscreen it, and the child window would still be drawn above other
floating clients. Avoid dealing with this edge case to keep the line
count low.
These cases can be tested by pressing Ctrl+o in applications with an
open file dialog.
2024-02-05 16:00:28 -06:00
Guido Cella
17c5cbbf7b
make XWayland clients inherit tags and monitors
...
Revert 3213088
because the linked bug can no longer be reproduced with
wlroots 0.17, and update client_get_parent() so it doesn't segfault with
XWayland surfaces. This also allows reusing the p variable in the next
commit.
2024-02-05 15:59:46 -06:00
Guido Cella
45e3694fc8
remove useless wlr_scene_node_reparent() calls
...
These don't do anything because wlr_scene_node_reparent() is immediately
called again by setfloating() through setmon(). They are also a source
of confusion because if you change the wlr_scene_node_reparent() call in
applyrules() it takes a while to understand why it doesn't work.
2024-02-05 15:59:46 -06:00
Leonardo Hernández Hernández
5c936efc42
Revert "No need to call updatemons ourselves"
...
Fixes: https://codeberg.org/dwl/dwl/issues/577
This reverts commit 26d7c9689f
.
2024-01-30 22:54:54 -06:00
A Frederick Christensen
9830a991ff
Correct specifier-data_type mismatches
2024-01-26 23:12:35 -06:00
Guido Cella
863634a61c
configure xwayland surfaces without monitors
...
For wine clients often configurex11() is called before mapnotify() and
therefore c->mon is NULL. configurex11 just returns early in that case,
letting these clients stay in the wrong size. For example only the top
left part of winecfg and wine uninstaller is drawn, or confirmation
dialogs like when closing wine notepad are too big. Fix this by
configuring their surfaces like before 88d386b
.
2024-01-25 19:47:34 -06:00
Guido Cella
ac6074f4fd
implement the virtual pointer protocol
...
This is used by programs like warpd.
2024-01-25 17:13:01 +00:00
Leonardo Hernández Hernández
433385f7f1
do not arrange monitor if it's disabled (wlroots!4520)
...
This causes us to send negative values to xdg-configures (e.g a bug in our end)
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4520
(cherry picked from commit 4043fc3093a73174cb63653ba9e742b4738f2ee5)
2024-01-24 13:36:46 -06:00
Devin J. Pohly
26d7c9689f
No need to call updatemons ourselves
...
The output manager in wlroots emits an output_layout.change event when
anything changes, so updatemons will be called anyway.
ΔSLOC: -1
2024-01-20 21:51:20 -06:00
Leonardo Hernández Hernández
6c8be38ec4
drop unused variable
2024-01-15 02:19:02 +00:00
Leonardo Hernández Hernández
417e37f988
request description before logs
2024-01-15 02:15:54 +00:00
Leonardo Hernández Hernández
a1f3e25c35
turn on -Wfloat-conversion
2024-01-15 02:09:18 +00:00
Leonardo Hernández Hernández
0151bd48dd
turn on -Wsign-compare
2024-01-15 02:09:18 +00:00
A Frederick Christensen
337d6ba3fb
acknowledgements refactoring
2024-01-14 09:01:49 -06:00
Leonardo Hernández Hernández
ec557f253b
clarify the code will be kept as small as possible
2024-01-12 22:34:09 -06:00
choc
fd263041a0
check if monitor is null before setting gamma
...
fixes segfault on monitor disconnect when using wlsunset
2024-01-11 17:17:57 +08:00
Leonardo Hernández Hernández
a73afc66ab
drop SLOC limit
2024-01-10 20:50:34 -06:00
Leonardo Hernández Hernández
f5b046ce9e
prefer functionality over philosophy
2024-01-10 00:20:11 -06:00
Leonardo Hernández Hernández
6340989c8e
add acknowledgment to djpohly
2024-01-10 00:17:06 -06:00
Ben Jargowsky
25e34e4d0c
Destroy fullscreen node after moving clients off mon
2024-01-06 17:34:08 -08:00
Leonardo Hernández Hernández
f3c4f72314
fix posible NULL-dereference in wl_surface.commit handler
2024-01-01 00:51:01 -06:00
Leonardo Hernández Hernández
6cbf8e9b80
unset DISPLAY before setting up xwayland
2023-12-27 11:19:03 -06:00
Leonardo Hernández Hernández
d13015381b
only execute the first keybinding
2023-12-27 11:18:24 -06:00
Leonardo Hernández Hernández
e277d84c51
more style fixes
...
missed from the previous iteration
2023-12-27 11:17:52 -06:00
Leonardo Hernández Hernández
1f0afcfc28
create a wlr_keyboard_group for virtual keyboards
...
Fixes: https://codeberg.org/dwl/dwl/issues/554
2023-12-25 21:19:59 -06:00
Leonardo Hernández Hernández
23fd312409
fix typo
...
Fixes: 7afdc191fe
Thanks to: David Donahue <david.donahue2996@gmail.com>
2023-12-18 14:08:09 -06:00
Leonardo Hernández Hernández
e39d931430
tie xdg_toplevel_decorations to Client
...
a xdg_toplevel can only have one xdg_toplevel_decoration so there is no need to
have a new struct for decorations
2023-12-18 12:59:47 -06:00
Leonardo Hernández Hernández
396840cdf2
Revert "nuke CSDs, hopefully for good!"
...
The compositor must respond to the client requesting a change to the decoration
mode, it does not matter if the compositor chooses a different mode.
This reverts commit 9071ce6c84
.
2023-12-18 12:56:20 -06:00
Leonardo Hernández Hernández
a71b368483
Revert "remove typedef Decoration
"
...
This reverts commit d1ff1e6f75
.
2023-12-18 12:56:19 -06:00
Leonardo Hernández Hernández
7afdc191fe
style fixes
2023-12-17 21:42:50 +00:00
David Donahue
023efce6eb
use wlr_keyboard_group to manage all keyboards
2023-12-17 21:41:39 +00:00
Leonardo Hernández Hernández
fa660fb61e
check toplevel resources
...
it's just a aesthetic change
2023-12-12 22:21:32 -06:00
Dima Krasner
9a84789ff1
restore and respect rootcolor
2023-12-11 00:30:17 -06:00
Leonardo Hernández Hernández
49bfe92703
merge X11Managed and X11Unmanaged into X11
...
now that client_is_unmanaged() checks the wlr struct we don't need to keep
track of it ourselves
2023-12-10 23:46:49 -06:00
Leonardo Hernández Hernández
c88960751d
check if a client is unmanaged checking the o-r flag
...
it may change at any moment and I don't really want to add a listener for it
2023-12-10 23:46:40 -06:00
Leonardo Hernández Hernández
9c5bdcfbe8
do not blindly try to send motion events when pointer button is pressed
...
we don't have to do this if the surface is the same
2023-12-10 23:27:59 -06:00
Leonardo Hernández Hernández
1884a07646
sort LISTEN calls in createnotify{,x11}
2023-12-07 22:40:59 -06:00
Leonardo Hernández Hernández
79c51a4584
use the same style for urgent() and sethints()
2023-12-07 22:37:35 -06:00
Leonardo Hernández Hernández
f5d839844d
remove an unneeded cast in createpointer()
2023-12-07 22:37:00 -06:00
Leonardo Hernández Hernández
e03896b4d6
avoid duplication of lines
...
the output state is copied when creating a output configuration head
2023-12-07 22:18:49 -06:00
Leonardo Hernández Hernández
e7e84b1083
add explanation about why we try to re-apply the gamma LUT on output changes
2023-12-07 22:17:48 -06:00
Leonardo Hernández Hernández
9694477b2f
relax a bit the line length limit
2023-12-07 22:16:13 -06:00
Leonardo Hernández Hernández
6a15167754
add a blank line to improve readability
2023-12-07 22:15:42 -06:00
Leonardo Hernández Hernández
e5e2d1c28f
use (struct wlr_box){0} to empty the Monitor areas
2023-12-07 22:04:24 -06:00
Leonardo Hernández Hernández
bdbfb45d66
copy layout symbol when matching a MonitorRule
2023-12-07 21:51:24 -06:00
Leonardo Hernández Hernández
50ea84c5f6
remove extra blank line
2023-12-07 21:49:26 -06:00
Leonardo Hernández Hernández
472a31b5a4
LayerSurface::link -> LayerSurface.link
2023-12-07 21:48:56 -06:00
Leonardo Hernández Hernández
a760757b82
set the correct border color when mapping a client
2023-12-07 21:44:53 -06:00
Leonardo Hernández Hernández
80c9ad12ba
reduce calls to client_get_geometry
2023-12-07 21:43:48 -06:00
Leonardo Hernández Hernández
7341d047da
add a note about not removing the default rule
...
Closes: https://codeberg.org/dwl/dwl/issues/527
2023-12-07 14:20:49 -06:00