Convert measurement `api/v1/admin/*` controller specs to request specs (#28005)

This commit is contained in:
Matt Jankowski 2023-11-21 09:25:07 -05:00 committed by GitHub
parent f91e751383
commit 30ee4aaff4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 105 additions and 69 deletions

View File

@ -1,23 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
describe Api::V1::Admin::DimensionsController do
render_views
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'admin:read') }
let(:account) { Fabricate(:account) }
before do
allow(controller).to receive(:doorkeeper_token) { token }
end
describe 'POST #create' do
it 'returns http success' do
post :create, params: { account_id: account.id, limit: 2 }
expect(response).to have_http_status(200)
end
end
end

View File

@ -1,23 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
describe Api::V1::Admin::MeasuresController do
render_views
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'admin:read') }
let(:account) { Fabricate(:account) }
before do
allow(controller).to receive(:doorkeeper_token) { token }
end
describe 'POST #create' do
it 'returns http success' do
post :create, params: { account_id: account.id, limit: 2 }
expect(response).to have_http_status(200)
end
end
end

View File

@ -1,23 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
describe Api::V1::Admin::RetentionController do
render_views
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'admin:read') }
let(:account) { Fabricate(:account) }
before do
allow(controller).to receive(:doorkeeper_token) { token }
end
describe 'POST #create' do
it 'returns http success' do
post :create, params: { account_id: account.id, limit: 2 }
expect(response).to have_http_status(200)
end
end
end

View File

@ -0,0 +1,35 @@
# frozen_string_literal: true
require 'rails_helper'
describe 'Admin Dimensions' do
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
let(:headers) { { 'Authorization' => "Bearer #{token.token}" } }
let(:account) { Fabricate(:account) }
describe 'GET /api/v1/admin/dimensions' do
context 'when not authorized' do
it 'returns http forbidden' do
post '/api/v1/admin/dimensions', params: { account_id: account.id, limit: 2 }
expect(response)
.to have_http_status(403)
end
end
context 'with correct scope' do
let(:scopes) { 'admin:read' }
it 'returns http success and status json' do
post '/api/v1/admin/dimensions', params: { account_id: account.id, limit: 2 }, headers: headers
expect(response)
.to have_http_status(200)
expect(body_as_json)
.to be_an(Array)
end
end
end
end

View File

@ -0,0 +1,35 @@
# frozen_string_literal: true
require 'rails_helper'
describe 'Admin Measures' do
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
let(:headers) { { 'Authorization' => "Bearer #{token.token}" } }
let(:account) { Fabricate(:account) }
describe 'GET /api/v1/admin/measures' do
context 'when not authorized' do
it 'returns http forbidden' do
post '/api/v1/admin/measures', params: { account_id: account.id, limit: 2 }
expect(response)
.to have_http_status(403)
end
end
context 'with correct scope' do
let(:scopes) { 'admin:read' }
it 'returns http success and status json' do
post '/api/v1/admin/measures', params: { account_id: account.id, limit: 2 }, headers: headers
expect(response)
.to have_http_status(200)
expect(body_as_json)
.to be_an(Array)
end
end
end
end

View File

@ -0,0 +1,35 @@
# frozen_string_literal: true
require 'rails_helper'
describe 'Admin Retention' do
let(:user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
let(:headers) { { 'Authorization' => "Bearer #{token.token}" } }
let(:account) { Fabricate(:account) }
describe 'GET /api/v1/admin/retention' do
context 'when not authorized' do
it 'returns http forbidden' do
post '/api/v1/admin/retention', params: { account_id: account.id, limit: 2 }
expect(response)
.to have_http_status(403)
end
end
context 'with correct scope' do
let(:scopes) { 'admin:read' }
it 'returns http success and status json' do
post '/api/v1/admin/retention', params: { account_id: account.id, limit: 2 }, headers: headers
expect(response)
.to have_http_status(200)
expect(body_as_json)
.to be_an(Array)
end
end
end
end