2023-02-21 19:55:31 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2021-08-09 17:11:50 -04:00
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
describe Scheduler::AccountsStatusesCleanupScheduler do
|
|
|
|
subject { described_class.new }
|
|
|
|
|
|
|
|
let!(:account1) { Fabricate(:account, domain: nil) }
|
|
|
|
let!(:account2) { Fabricate(:account, domain: nil) }
|
|
|
|
let!(:account3) { Fabricate(:account, domain: nil) }
|
|
|
|
let!(:account4) { Fabricate(:account, domain: nil) }
|
2023-04-23 16:25:40 -04:00
|
|
|
let!(:account5) { Fabricate(:account, domain: nil) }
|
2021-08-09 17:11:50 -04:00
|
|
|
let!(:remote) { Fabricate(:account) }
|
|
|
|
|
|
|
|
let(:queue_size) { 0 }
|
|
|
|
let(:queue_latency) { 0 }
|
|
|
|
let(:process_set_stub) do
|
|
|
|
[
|
|
|
|
{
|
|
|
|
'concurrency' => 2,
|
2023-02-20 00:14:10 -05:00
|
|
|
'queues' => %w(push default),
|
2021-08-09 17:11:50 -04:00
|
|
|
},
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
2023-06-14 03:56:11 -04:00
|
|
|
queue_stub = instance_double(Sidekiq::Queue, size: queue_size, latency: queue_latency)
|
2021-08-09 17:11:50 -04:00
|
|
|
allow(Sidekiq::Queue).to receive(:new).and_return(queue_stub)
|
|
|
|
allow(Sidekiq::ProcessSet).to receive(:new).and_return(process_set_stub)
|
|
|
|
|
2023-06-14 03:56:11 -04:00
|
|
|
sidekiq_stats_stub = instance_double(Sidekiq::Stats)
|
2021-08-09 17:11:50 -04:00
|
|
|
allow(Sidekiq::Stats).to receive(:new).and_return(sidekiq_stats_stub)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#under_load?' do
|
|
|
|
context 'when nothing is queued' do
|
|
|
|
it 'returns false' do
|
|
|
|
expect(subject.under_load?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when numerous jobs are queued' do
|
|
|
|
let(:queue_size) { 5 }
|
|
|
|
let(:queue_latency) { 120 }
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(subject.under_load?).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-03 04:31:40 -04:00
|
|
|
describe '#compute_budget' do
|
2023-05-03 23:49:08 -04:00
|
|
|
context 'with a single thread' do
|
2023-02-20 00:14:10 -05:00
|
|
|
let(:process_set_stub) { [{ 'concurrency' => 1, 'queues' => %w(push default) }] }
|
2021-08-09 17:11:50 -04:00
|
|
|
|
|
|
|
it 'returns a low value' do
|
|
|
|
expect(subject.compute_budget).to be < 10
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-03 23:49:08 -04:00
|
|
|
context 'with a lot of threads' do
|
2021-08-09 17:11:50 -04:00
|
|
|
let(:process_set_stub) do
|
|
|
|
[
|
2023-02-20 00:14:10 -05:00
|
|
|
{ 'concurrency' => 2, 'queues' => %w(push default) },
|
2021-08-09 17:11:50 -04:00
|
|
|
{ 'concurrency' => 2, 'queues' => ['push'] },
|
|
|
|
{ 'concurrency' => 2, 'queues' => ['push'] },
|
|
|
|
{ 'concurrency' => 2, 'queues' => ['push'] },
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a larger value' do
|
|
|
|
expect(subject.compute_budget).to be > 10
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#perform' do
|
2023-06-14 03:56:11 -04:00
|
|
|
before do
|
|
|
|
# Policies for the accounts
|
|
|
|
Fabricate(:account_statuses_cleanup_policy, account: account1)
|
|
|
|
Fabricate(:account_statuses_cleanup_policy, account: account3)
|
|
|
|
Fabricate(:account_statuses_cleanup_policy, account: account4, enabled: false)
|
|
|
|
Fabricate(:account_statuses_cleanup_policy, account: account5)
|
|
|
|
|
|
|
|
# Create a bunch of old statuses
|
|
|
|
4.times do
|
|
|
|
Fabricate(:status, account: account1, created_at: 3.years.ago)
|
|
|
|
Fabricate(:status, account: account2, created_at: 3.years.ago)
|
|
|
|
Fabricate(:status, account: account3, created_at: 3.years.ago)
|
|
|
|
Fabricate(:status, account: account4, created_at: 3.years.ago)
|
|
|
|
Fabricate(:status, account: account5, created_at: 3.years.ago)
|
|
|
|
Fabricate(:status, account: remote, created_at: 3.years.ago)
|
2021-08-09 17:11:50 -04:00
|
|
|
end
|
|
|
|
|
2023-06-14 03:56:11 -04:00
|
|
|
# Create a bunch of newer statuses
|
|
|
|
Fabricate(:status, account: account1, created_at: 3.minutes.ago)
|
|
|
|
Fabricate(:status, account: account2, created_at: 3.minutes.ago)
|
|
|
|
Fabricate(:status, account: account3, created_at: 3.minutes.ago)
|
|
|
|
Fabricate(:status, account: account4, created_at: 3.minutes.ago)
|
|
|
|
Fabricate(:status, account: remote, created_at: 3.minutes.ago)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the budget is lower than the number of toots to delete' do
|
|
|
|
it 'deletes the appropriate statuses' do
|
|
|
|
expect(Status.count).to be > (subject.compute_budget) # Data check
|
2021-08-09 17:11:50 -04:00
|
|
|
|
2023-06-14 03:56:11 -04:00
|
|
|
expect { subject.perform }
|
|
|
|
.to change(Status, :count).by(-subject.compute_budget) # Cleanable statuses
|
|
|
|
.and (not_change { account2.statuses.count }) # No cleanup policy for account
|
|
|
|
.and(not_change { account4.statuses.count }) # Disabled cleanup policy
|
2021-08-09 17:11:50 -04:00
|
|
|
end
|
|
|
|
|
2023-04-23 16:25:40 -04:00
|
|
|
it 'eventually deletes every deletable toot given enough runs' do
|
|
|
|
stub_const 'Scheduler::AccountsStatusesCleanupScheduler::MAX_BUDGET', 4
|
|
|
|
|
2023-06-14 03:56:11 -04:00
|
|
|
expect { 3.times { subject.perform } }.to change(Status, :count).by(-cleanable_statuses_count)
|
2023-04-23 16:25:40 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'correctly round-trips between users across several runs' do
|
|
|
|
stub_const 'Scheduler::AccountsStatusesCleanupScheduler::MAX_BUDGET', 3
|
|
|
|
stub_const 'Scheduler::AccountsStatusesCleanupScheduler::PER_ACCOUNT_BUDGET', 2
|
|
|
|
|
|
|
|
expect { 3.times { subject.perform } }
|
2023-05-24 05:23:40 -04:00
|
|
|
.to change(Status, :count).by(-3 * 3)
|
2023-04-23 16:25:40 -04:00
|
|
|
.and change { account1.statuses.count }
|
|
|
|
.and change { account3.statuses.count }
|
2023-06-14 03:56:11 -04:00
|
|
|
.and(change { account5.statuses.count })
|
2021-08-09 17:11:50 -04:00
|
|
|
end
|
2023-05-03 04:31:40 -04:00
|
|
|
|
|
|
|
context 'when given a big budget' do
|
|
|
|
let(:process_set_stub) { [{ 'concurrency' => 400, 'queues' => %w(push default) }] }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_const 'Scheduler::AccountsStatusesCleanupScheduler::MAX_BUDGET', 400
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'correctly handles looping in a single run' do
|
|
|
|
expect(subject.compute_budget).to eq(400)
|
2023-06-14 03:56:11 -04:00
|
|
|
expect { subject.perform }.to change(Status, :count).by(-cleanable_statuses_count)
|
2023-05-03 04:31:40 -04:00
|
|
|
end
|
|
|
|
end
|
2023-05-04 04:13:00 -04:00
|
|
|
|
|
|
|
context 'when there is no work to be done' do
|
|
|
|
let(:process_set_stub) { [{ 'concurrency' => 400, 'queues' => %w(push default) }] }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_const 'Scheduler::AccountsStatusesCleanupScheduler::MAX_BUDGET', 400
|
|
|
|
subject.perform
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not get stuck' do
|
|
|
|
expect(subject.compute_budget).to eq(400)
|
2023-05-24 05:23:40 -04:00
|
|
|
expect { subject.perform }.to_not change(Status, :count)
|
2023-05-04 04:13:00 -04:00
|
|
|
end
|
|
|
|
end
|
2023-06-14 03:56:11 -04:00
|
|
|
|
|
|
|
def cleanable_statuses_count
|
|
|
|
Status
|
|
|
|
.where(account_id: [account1, account3, account5]) # Accounts with enabled policies
|
|
|
|
.where('created_at < ?', 2.weeks.ago) # Policy defaults is 2.weeks
|
|
|
|
.count
|
|
|
|
end
|
2021-08-09 17:11:50 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|