Re-ordered and organized a few things #2
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: supernets/inspircd#2
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "acidvegas/inspircd:master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Removed dis-allowing people to connect from root
Added block and changed the ipv6clone default from 128 to 64 bits,
Removed missingokay=yes from includes as thjis is already the default
Added DNSBL logging for fun experiments
removed "largechan" from maxlist as that io
removed LIST_NORMAL_SIZE as it was incorrect and just used LIST_MAX_SIZE (changed to 100)
moved motd and oper motd into /custom
added supernets motd
looks good, something I am not sure of is where we stand without the majority of what was contained in the
includes.conf
now that it absent. One way to be sure is to build the container without docker-compose and just see what it does:docker build -t mycustomname -t mycustomname:latest .
docker run --net host -e 'DEFAULT_BLOCK_HOST_MASK="nothing@nowhere.nadda"' -it --rm -v /tmp/inspi4_custom:/etc/inspircd/custom
This should create a default
lame-network.local
instance that you can actually connect to. TheDEFAULT_BLOCK_HOST_MASK
variable by default is*@*
so everything unless otherwise specified. This is one of those unfortunate configuration options that you either specify or not at all (a blank string is an error so you must otherwise specify a host mask that is unlikely to ever exist as the only default block host mask.)My only suggestion would be to maintain some posterity with keeping the image functionality reproducible meaning you can simply build and run it and it will always do something relatively relatable. In my experience with Docker this is a good idea and it helps people figure out how it works easier given little to no context.
TLDR: there are a lot of shit containers that people make and its difficult to tell whether they ever worked or not sometimes and fwiw I have just gotten good at making my own because of it but if I could offer you my insight it's helpful for testing and makes completing substantial changes like this a lot smoother
for that matter I should have also put a git commit into this to be used as a build arg, which you can test by passing
--build-arg GIT_COMMIT=inspi4commithash
to thedocker build
command and also modifying the git clone step to use that specific git hash as well as specifying the specific ubuntu release tag for theFROM
instruction in the Dockerfile. I could be mistaken but I believe the latest isjammy
as per Docker Hub:https://hub.docker.com/_/ubuntu/tags
and by doing this you can endorse a little more reliability in terms of something that is always reproducible but of course it's no longer a rolling image.
I know it seems a tad backwards to test things in a manner that doesn't rely at all on docker-compose given that the way this is primarily used is in the context of a docker-compose environment, but I like to thing of docker-compose not as a dependency but rather just a tool for doing orchestration and containers should operate as though docker-compose is completely optional. That said I think part of the
docker build
step should include adding ainclude.conf
of some basic form (even though it will be overridden) just because it serves to aid in reproduction and testing but also relieves us of having to substantiate external volumes and files withdocker run
like-v $(pwd)/whatever.conf:/etc/whatever
....apologies, the .gitignore file was blocking the
custom/
dir from uploading on mygit push
I have re added it as this was not the intention: acidvegas/inspircd/commit/09e99d2122c1db46740daa1fe34cb69743dd3f18
add this to
/tmp/patch
:then in the src dir run
git patch apply /tmp/patch
Test:
docker build -t testimage -t testimage:latest .
docker run -it --rm testimage
Notes:
also something I forgot to include in the patch:
ENV CLOAK_KEY="changeme"
change this toENV CLOAK_KEY="changemechangemechangemechangeme"
Applied and pushed this patch as a commit aswell as the
ENV_CLOAK_KEY
change