supernets/hardlounge
supernets/hardlounge
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2043 from thelounge/xpaw/preview-on-failed-img

Browse Source 
Still render link previews if image fails to load
This commit is contained in:
Jérémie Astori 2018-02-08 01:55:02 -05:00 committed by GitHub
commit 7883feca30
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
client/js/renderPreview.js
View File

@ -27,6 +27,15 @@ function renderPreview(preview, msg) {
// If there is an image in preview, wait for it to load before appending it to DOM // If there is an image in preview, wait for it to load before appending it to DOM
// This is done to prevent problems keeping scroll to the bottom while images load // This is done to prevent problems keeping scroll to the bottom while images load
image.on("load", () => appendPreview(preview, msg, template)); image.on("load", () => appendPreview(preview, msg, template));
// If the image fails to load, remove it from DOM and still render the preview
if (preview.type === "link") {
image.on("abort error", () => {
image.parent().remove();
appendPreview(preview, msg, template);
});
}
} }
function appendPreview(preview, msg, template) { function appendPreview(preview, msg, template) {