Merge pull request #684 from thelounge/astorije/strict-mode

Strict mode for all JS files

.eslintrc.yml

@@ -34,6 +34,7 @@ rules:
   space-before-blocks: 2
   space-infix-ops: 2
   spaced-comment: [2, always]
+  strict: 2
 
 globals:
   log: false

client/js/libs/handlebars/diff.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var diff;
 
 Handlebars.registerHelper(

client/js/libs/handlebars/equal.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Handlebars.registerHelper(
 	"equal", function(a, b, opt) {
 		a = a.toString();

client/js/libs/handlebars/modes.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Handlebars.registerHelper(
 	"modes", function(mode) {
 		var modes = {

client/js/libs/handlebars/parse.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Handlebars.registerHelper(
 	"parse", function(text) {
 		text = Handlebars.Utils.escapeExpression(text);

client/js/libs/handlebars/roundBadgeNumber.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Handlebars.registerHelper(
 	"roundBadgeNumber", function(count) {
 		if (count < 1000) {

client/js/libs/handlebars/tz.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Handlebars.registerHelper(
 	"tz", function(time) {
 		time = new Date(time);

client/js/libs/handlebars/users.js

@@ -1,3 +1,5 @@
+"use strict";
+
 Handlebars.registerHelper(
 	"users", function(count) {
 		return count + " " + (count === 1 ? "user" : "users");

client/js/loading-slow-alert.js

@@ -1,3 +1,5 @@
+"use strict";
+
 /*
  * This is a separate file for two reasons:
  * 1. CSP policy does not allow inline javascript

client/js/lounge.js

@@ -1,3 +1,5 @@
+"use strict";
+
 $(function() {
 	$("#loading-page-message").text("Connecting…");
 

defaults/config.js

@@ -1,3 +1,5 @@
+"use strict";
+
 module.exports = {
 	//
 	// Set the server mode.

index.js

@@ -1,4 +1,7 @@
 #!/usr/bin/env node
+
+"use strict";
+
 process.chdir(__dirname);
 
 // Perform node version check before loading any other files or modules

src/client.js

@@ -1,5 +1,7 @@
+"use strict";
+
 var _ = require("lodash");
-var package = require("../package.json");
+var pkg = require("../package.json");
 var Chan = require("./models/chan");
 var crypto = require("crypto");
 var userLog = require("./userLog");
@@ -228,7 +230,7 @@ Client.prototype.connect = function(args) {
 			} else {
 				webirc = {
 					password: config.webirc[network.host],
-					username: package.name,
+					username: pkg.name,
 					address: args.ip,
 					hostname: args.hostname
 				};
@@ -255,7 +257,7 @@ Client.prototype.connect = function(args) {
 	});
 
 	network.irc.connect({
-		version: package.name + " " + package.version + " -- " + package.homepage,
+		version: pkg.name + " " + pkg.version + " -- " + pkg.homepage,
 		host: network.host,
 		port: network.port,
 		nick: nick,

src/clientManager.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var fs = require("fs");
 var Client = require("./client");

src/command-line/add.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var ClientManager = new require("../clientManager");
 var bcrypt = require("bcrypt-nodejs");
 var program = require("commander");

src/command-line/config.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var program = require("commander");
 var child = require("child_process");
 var Helper = require("../helper");

src/command-line/edit.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var ClientManager = new require("../clientManager");
 var program = require("commander");
 var child = require("child_process");

src/command-line/index.js

@@ -1,3 +1,5 @@
+"use strict";
+
 global.log = require("../log.js");
 
 var program = require("commander");

src/command-line/list.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var ClientManager = new require("../clientManager");
 var program = require("commander");
 

src/command-line/remove.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var ClientManager = new require("../clientManager");
 var program = require("commander");
 

src/command-line/reset.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var bcrypt = require("bcrypt-nodejs");
 var ClientManager = new require("../clientManager");
 var fs = require("fs");

src/command-line/start.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var ClientManager = new require("../clientManager");
 var program = require("commander");
 var server = require("../server");

src/helper.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var path = require("path");
 var os = require("os");

src/identd.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var net = require("net");
 

src/log.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var colors = require("colors/safe");
 var moment = require("moment");
 var Helper = require("./helper");

src/models/chan.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Helper = require("../helper");
 

src/models/msg.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 
 Msg.Type = {

src/models/network.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Chan = require("./chan");
 

src/models/user.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 
 module.exports = User;

src/oidentd.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require("fs");
 var Helper = require("./helper");
 

src/plugins/inputs/action.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["slap", "me"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/connect.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 exports.commands = ["connect", "server"];

src/plugins/inputs/ctcp.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["ctcp"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/disconnect.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["disconnect"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/invite.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Chan = require("../../models/chan");
 
 exports.commands = ["invite"];

src/plugins/inputs/kick.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["kick"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/list.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["list"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/mode.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["mode", "op", "voice", "deop", "devoice"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/msg.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["msg", "say"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/nick.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 exports.commands = ["nick"];

src/plugins/inputs/notice.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["notice"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/part.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Msg = require("../../models/msg");
 var Chan = require("../../models/chan");

src/plugins/inputs/query.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Chan = require("../../models/chan");
 var Msg = require("../../models/msg");

src/plugins/inputs/quit.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 
 exports.commands = ["quit"];

src/plugins/inputs/raw.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["raw", "send", "quote"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/inputs/topic.js

@@ -1,3 +1,5 @@
+"use strict";
+
 exports.commands = ["topic"];
 
 exports.input = function(network, chan, cmd, args) {

src/plugins/irc-events/connection.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var identd = require("../../identd");
 var Msg = require("../../models/msg");

src/plugins/irc-events/ctcp.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/error.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/invite.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/join.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Chan = require("../../models/chan");
 var Msg = require("../../models/msg");
 var User = require("../../models/user");

src/plugins/irc-events/kick.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Msg = require("../../models/msg");
 

src/plugins/irc-events/link.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var cheerio = require("cheerio");
 var Msg = require("../../models/msg");

src/plugins/irc-events/list.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Chan = require("../../models/chan");
 var Msg = require("../../models/msg");
 

src/plugins/irc-events/message.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Chan = require("../../models/chan");
 var Msg = require("../../models/msg");
 

src/plugins/irc-events/mode.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Chan = require("../../models/chan");
 var Msg = require("../../models/msg");

src/plugins/irc-events/motd.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/names.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var User = require("../../models/user");
 

src/plugins/irc-events/nick.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Msg = require("../../models/msg");
 

src/plugins/irc-events/part.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Msg = require("../../models/msg");
 

src/plugins/irc-events/quit.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var _ = require("lodash");
 var Msg = require("../../models/msg");
 

src/plugins/irc-events/topic.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/unhandled.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/welcome.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Msg = require("../../models/msg");
 
 module.exports = function(irc, network) {

src/plugins/irc-events/whois.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var Chan = require("../../models/chan");
 var Msg = require("../../models/msg");
 

src/userLog.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require("fs");
 var fsextra = require("fs-extra");
 var moment = require("moment");

test/fixtures/.lounge/config.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var config = require("../../../defaults/config.js");
 
 config.prefetch = true;

test/fixtures/env.js

@@ -1,2 +1,4 @@
+"use strict";
+
 var home = require("path").join(__dirname, ".lounge");
 require("../../src/helper").setHome(home);

test/plugins/link.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var assert = require("assert");
 
 var util = require("../util");

test/util.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var EventEmitter = require("events").EventEmitter;
 var util = require("util");
 var _ = require("lodash");