supernets/hardlounge
supernets/hardlounge
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4040 from thelounge/xpaw/media-embed

Browse Source 
Skip video/audio embeds if og:type exists but does not specify it
This commit is contained in:
Pavel Djundik 2020-08-23 20:46:36 +03:00 committed by GitHub
commit 4307d2da9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/irc-events/link.js
View File

@ -131,9 +131,23 @@ function parseHtmlMedia($, preview, client) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
if (Helper.config.disableMediaPreview) { if (Helper.config.disableMediaPreview) {
reject(); reject();
return;
} }
let foundMedia = false; let foundMedia = false;
const openGraphType = $('meta[property="og:type"]').attr("content");
// Certain news websites may include video and audio tags,
// despite actually being an article (as indicated by og:type).
// If there is og:type tag, we will only select video or audio if it matches
if (
openGraphType &&
!openGraphType.startsWith("video") &&
!openGraphType.startsWith("music")
) {
reject();
return;
}
["video", "audio"].forEach((type) => { ["video", "audio"].forEach((type) => {
if (foundMedia) { if (foundMedia) {