Apply suggestions from code review
Co-authored-by: Mina Galić <me+github@igalic.co>
This commit is contained in:
parent
243cb10e2a
commit
26b7fbf2c0
@ -120,9 +120,9 @@ class Identification {
|
|||||||
if (!connection.socket.remotePort || !connection.socket.localPort) {
|
if (!connection.socket.remotePort || !connection.socket.localPort) {
|
||||||
// Race condition: this can happen when more than one socket gets disconnected at
|
// Race condition: this can happen when more than one socket gets disconnected at
|
||||||
// once, since we `refresh()` for each one being added/removed. This results
|
// once, since we `refresh()` for each one being added/removed. This results
|
||||||
// in there possibly be one or more disconnected sockets remaining when we get here.
|
// in there possibly being one or more disconnected sockets remaining when we get here.
|
||||||
//
|
//
|
||||||
// Simply skip this socket and not crash the server.
|
// Simply skip this socket and do not crash the server.
|
||||||
log.warn("oidentd: socket has no remote or local port?");
|
log.warn("oidentd: socket has no remote or local port?");
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user