supernets/hardlounge
supernets/hardlounge
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1955 from thelounge/xpaw/fix-touch-select

Browse Source 
Prevent user contextmenu from opening while selecting text
This commit is contained in:
Jérémie Astori 2018-01-29 01:07:36 -05:00 committed by GitHub
commit 2640c2a15e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
client/js/lounge.js
View File

@ -170,6 +170,12 @@ $(function() {
});
viewport.on("click contextmenu", ".user", function(e) {
// If user is selecting text, do not open context menu
// This primarily only targets mobile devices where selection is performed with touch
if (!window.getSelection().isCollapsed) {
return true;
}
return showContextMenu(this, e);
});
@ -218,13 +224,7 @@ $(function() {
chat.on("click", ".chat", function() {
setTimeout(function() {
var text = "";
if (window.getSelection) {
text = window.getSelection().toString();
} else if (document.selection && document.selection.type !== "Control") {
text = document.selection.createRange().text;
}
if (!text) {
if (window.getSelection().isCollapsed) {
focus();
}
}, 2);