supernets/hardlounge
supernets
/
hardlounge
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Be more explicit on the process workflow in the CONTRIBUTING file

This commit is contained in:
Jérémie Astori 2015-10-08 03:58:26 +00:00
parent 9afa0ce2d1
commit 1671858e9c
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
CONTRIBUTING.md
View File

@ -41,9 +41,13 @@ when necessary. Tim Pope wrote an [excellent
article](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) article](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
on how one should format their commit messages. on how one should format their commit messages.
When you send your PR, expect two different reviews from the project When you send a PR, expect two different reviews from the project maintainers.
maintainers. They will make comments and give their respective :+1: before your If necessary, they will make comments and ask for changes. When everything looks
changes can go into production. good to them, they will both express their consent by commenting your PR with a
:+1:. Typically, the first reviewer will give a thorough report and exchange
with you, give his :+1:, then ask the second reviewer to confirm the changes.
When this happens (when you get your second required :+1:), then your PR can be
merged.
Please document any relevant changes in the shout documentation that can be Please document any relevant changes in the shout documentation that can be
found [in its own repository](https://github.com/erming/shout-website). found [in its own repository](https://github.com/erming/shout-website).