supernets/hardlounge
supernets/hardlounge
4
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1254 from thelounge/xpaw/thumb-is-img

Browse Source 
Make sure thumbnail is a valid image
This commit is contained in:
Jérémie Astori 2017-06-26 01:46:20 -04:00 committed by GitHub
commit 147a36adde
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/plugins/irc-events/link.js
View File

@ -62,6 +62,25 @@ function parse(msg, url, res, client) {
$("meta[property=\"og:image\"]").attr("content")
|| $("meta[name=\"twitter:image:src\"]").attr("content")
|| "";
// Make sure thumbnail is a valid url
if (!/^https?:\/\//.test(toggle.thumb)) {
toggle.thumb = "";
}
// Verify that thumbnail pic exists and is under allowed size
if (toggle.thumb.length) {
fetch(escapeHeader(toggle.thumb), (resThumb) => {
if (!(/^image\/.+/.test(resThumb.type)) || resThumb.size > (Helper.config.prefetchMaxImageSize * 1024)) {
toggle.thumb = "";
}
client.emit("toggle", toggle);
});
return;
}
break;
case "image/png":
@ -100,7 +119,7 @@ function fetch(url, cb) {
var limit = Helper.config.prefetchMaxImageSize * 1024;
req
.on("response", function(res) {
if (!(/(image\/.+)/.test(res.headers["content-type"]))) {
if (!(/^image\/.+/.test(res.headers["content-type"]))) {
// if not image, limit download to 10kb, since we need only meta tags
limit = 1024 * 10;
}