supernets/hardlounge
supernets/hardlounge
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Restrict what the browser should try to autocomplete

Browse Source 
Browsers often autocomplete into wrong fields. Eg. wanting to put the password in a fields in the settings screen and then use a sudo random other fields for username etc.
This is rather annoying and can break someones configuration, thus we should only enable it on fields where it somewhat makes sense (name, server & password fields).
This commit is contained in:
Nachtalb 2021-04-04 03:28:13 +02:00
parent db9eb05dfa
commit 08f45eabb2
No known key found for this signature in database
GPG Key ID: E48DF13C07055D92
2 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/components/NetworkForm.vue
View File

@ -172,6 +172,7 @@
<input <input
id="connect:leaveMessage" id="connect:leaveMessage"
v-model="defaults.leaveMessage" v-model="defaults.leaveMessage"
autocomplete="off"
class="input" class="input"
name="leaveMessage" name="leaveMessage"
placeholder="The Lounge - https://thelounge.chat" placeholder="The Lounge - https://thelounge.chat"
@ -193,6 +194,7 @@ the server tab on new connection"
<textarea <textarea
id="connect:commands" id="connect:commands"
ref="commandsInput" ref="commandsInput"
autocomplete="off"
:value="defaults.commands ? defaults.commands.join('\n') : ''" :value="defaults.commands ? defaults.commands.join('\n') : ''"
class="input" class="input"
name="commands" name="commands"

25
client/components/Windows/Settings.vue
View File

@ -3,7 +3,13 @@
<div class="header"> <div class="header">
<SidebarToggle /> <SidebarToggle />
</div> </div>
<form ref="settingsForm" class="container" @change="onChange" @submit.prevent> <form
ref="settingsForm"
class="container"
autocomplete="off"
@change="onChange"
@submit.prevent
>
<h1 class="title">Settings</h1> <h1 class="title">Settings</h1>
<div> <div>
@ -411,10 +417,11 @@ your nickname or expressions defined in custom highlights."
> >
<h2 id="label-change-password">Change password</h2> <h2 id="label-change-password">Change password</h2>
<div class="password-container"> <div class="password-container">
<label for="old_password_input" class="sr-only"> Enter current password </label> <label for="current-password" class="sr-only"> Enter current password </label>
<RevealPassword v-slot:default="slotProps"> <RevealPassword v-slot:default="slotProps">
<input <input
id="old_password_input" id="current-password"
autocomplete="current-password"
:type="slotProps.isVisible ? 'text' : 'password'" :type="slotProps.isVisible ? 'text' : 'password'"
name="old_password" name="old_password"
class="input" class="input"
@ -423,26 +430,26 @@ your nickname or expressions defined in custom highlights."
</RevealPassword> </RevealPassword>
</div> </div>
<div class="password-container"> <div class="password-container">
<label for="new_password_input" class="sr-only"> <label for="new-password" class="sr-only"> Enter desired new password </label>
Enter desired new password
</label>
<RevealPassword v-slot:default="slotProps"> <RevealPassword v-slot:default="slotProps">
<input <input
id="new_password_input" id="new-password"
:type="slotProps.isVisible ? 'text' : 'password'" :type="slotProps.isVisible ? 'text' : 'password'"
name="new_password" name="new_password"
autocomplete="new-password"
class="input" class="input"
placeholder="Enter desired new password" placeholder="Enter desired new password"
/> />
</RevealPassword> </RevealPassword>
</div> </div>
<div class="password-container"> <div class="password-container">
<label for="verify_password_input" class="sr-only"> Repeat new password </label> <label for="new-password-verify" class="sr-only"> Repeat new password </label>
<RevealPassword v-slot:default="slotProps"> <RevealPassword v-slot:default="slotProps">
<input <input
id="verify_password_input" id="new-password-verify"
:type="slotProps.isVisible ? 'text' : 'password'" :type="slotProps.isVisible ? 'text' : 'password'"
name="verify_password" name="verify_password"
autocomplete="new-password"
class="input" class="input"
placeholder="Repeat new password" placeholder="Repeat new password"
/> />