Merge pull request #3578 from thelounge/xpaw/yarn-home

Provide fake $HOME env to Yarn commands

src/command-line/install.js

@@ -66,12 +66,7 @@ program
 					);
 				}
 
-				return Utils.executeYarnCommand(
+				return Utils.executeYarnCommand("add", "--exact", `${json.name}@${json.version}`)
-					"add",
-					"--production",
-					"--exact",
-					`${json.name}@${json.version}`
-				)
 					.then(() => {
 						log.info(
 							`${colors.green(

src/command-line/upgrade.js

@@ -18,7 +18,7 @@ program
 		const packagesPath = Helper.getPackagesPath();
 		const packagesConfig = path.join(packagesPath, "package.json");
 		const packagesList = JSON.parse(fs.readFileSync(packagesConfig)).dependencies;
-		const argsList = ["upgrade", "--production", "--latest"];
+		const argsList = ["upgrade", "--latest"];
 
 		let count = 0;
 

src/command-line/utils.js

@@ -106,14 +106,26 @@ class Utils {
 			"--non-interactive",
 		];
 
+		const env = {
+			// We only ever operate in production mode
+			NODE_ENV: "production",
+
+			// If The Lounge runs from a user that does not have a home directory,
+			// yarn may fail when it tries to read certain folders,
+			// we give it an existing folder so the reads do not throw a permission error.
+			// Yarn uses os.homedir() to figure out the path, which internally reads
+			// from the $HOME env on unix. On Windows it uses $USERPROFILE, but
+			// the user folder should always exist on Windows, so we don't set it.
+			HOME: cachePath,
+		};
+
 		return new Promise((resolve, reject) => {
 			let success = false;
-			const add = require("child_process").spawn(process.execPath, [
+			const add = require("child_process").spawn(
-				yarn,
+				process.execPath,
-				command,
+				[yarn, command, ...staticParameters, ...parameters],
-				...staticParameters,
+				{env: env}
-				...parameters,
+			);
-			]);
 
 			add.stdout.on("data", (data) => {
 				data.toString()