database: add NewUser

cmd/sojudb/main.go

@@ -74,13 +74,10 @@ func main() {
 			log.Fatalf("failed to hash password: %v", err)
 		}
 
-		user := database.User{
+		user := database.NewUser(username)
-			Username: username,
+		user.Password = string(hashed)
-			Password: string(hashed),
+		user.Admin = *admin
-			Admin:    *admin,
+		if err := db.StoreUser(ctx, user); err != nil {
-			Enabled:  true,
-		}
-		if err := db.StoreUser(ctx, &user); err != nil {
 			log.Fatalf("failed to create user: %v", err)
 		}
 	case "change-password":

contrib/znc-import/main.go

@@ -106,8 +106,9 @@ func main() {
 		if ok {
 			log.Printf("user %q: updating existing user", username)
 		} else {
+			u = database.NewUser(username)
 			// "!!" is an invalid crypt format, thus disables password auth
-			u = &database.User{Username: username, Password: "!!", Enabled: true}
+			u.Password = "!!"
 			usersCreated++
 			log.Printf("user %q: creating new user", username)
 		}

database/database.go

@@ -98,6 +98,13 @@ type User struct {
 	DownstreamInteractedAt time.Time
 }
 
+func NewUser(username string) *User {
+	return &User{
+		Username: username,
+		Enabled:  true,
+	}
+}
+
 func (u *User) CheckPassword(password string) (upgraded bool, err error) {
 	// Password auth disabled
 	if u.Password == "" {

server.go

@@ -515,11 +515,8 @@ func (s *Server) getOrCreateUser(ctx context.Context, username string) (*user, e
 	}
 
 	// Can't find the user in the DB -- try to create it
-	record := database.User{
+	record := database.NewUser(username)
-		Username: username,
+	user, err := s.createUser(ctx, record)
-		Enabled:  true,
-	}
-	user, err := s.createUser(ctx, &record)
 	if err != nil {
 		return nil, fmt.Errorf("failed to automatically create user %q after successful authentication: %v", username, err)
 	}

server_test.go

@@ -48,10 +48,7 @@ func createTempPostgresDB(t *testing.T) database.Database {
 }
 
 func createTestUser(t *testing.T, db database.Database) *database.User {
-	record := &database.User{
+	record := database.NewUser(testUsername)
-		Username: testUsername,
-		Enabled:  true,
-	}
 	if err := record.SetPassword(testPassword); err != nil {
 		t.Fatalf("failed to generate bcrypt hash: %v", err)
 	}

service.go

@@ -971,13 +971,11 @@ func handleUserCreate(ctx *serviceContext, params []string) error {
 		return fmt.Errorf("flag -password is required")
 	}
 
-	user := &database.User{
+	user := database.NewUser(*username)
-		Username: *username,
+	user.Nick = *nick
-		Nick:     *nick,
+	user.Realname = *realname
-		Realname: *realname,
+	user.Admin = *admin
-		Admin:    *admin,
+	user.Enabled = *enabled
-		Enabled:  *enabled,
-	}
 	if !*disablePassword {
 		if err := user.SetPassword(*password); err != nil {
 			return err