Make sure that WebSocket messages are valid UTF-8
... by replacing invalid bytes with the REPLACEMENT CHARACTER U+FFFD This is better than: - discarding the whole message, since the user would not see it... - removing invalid bytes, since the user would not see their presence, - converting the encoding (this is actually not possible). Contrary to its documentation, strings.ToValidUTF8 doesn't copy the string if it's valid UTF-8: <https://golang.org/src/strings/strings.go?s=15815:15861#L623>
This commit is contained in:
parent
046175f564
commit
42828d68e9
4
conn.go
4
conn.go
@ -5,8 +5,10 @@ import (
|
||||
"fmt"
|
||||
"io"
|
||||
"net"
|
||||
"strings"
|
||||
"sync"
|
||||
"time"
|
||||
"unicode"
|
||||
|
||||
"gopkg.in/irc.v3"
|
||||
"nhooyr.io/websocket"
|
||||
@ -62,7 +64,7 @@ func (wic websocketIRCConn) ReadMessage() (*irc.Message, error) {
|
||||
}
|
||||
|
||||
func (wic websocketIRCConn) WriteMessage(msg *irc.Message) error {
|
||||
b := []byte(msg.String())
|
||||
b := []byte(strings.ToValidUTF8(msg.String(), string(unicode.ReplacementChar)))
|
||||
ctx := context.Background()
|
||||
if !wic.writeDeadline.IsZero() {
|
||||
var cancel context.CancelFunc
|
||||
|
Loading…
Reference in New Issue
Block a user