Improve registration error messages
- Don't print the raw IRC message, since we already show the original error message - Avoid double-printing "registration failed"
This commit is contained in:
parent
bdb132ad98
commit
385825d010
17
upstream.go
17
upstream.go
@ -32,6 +32,12 @@ var permanentUpstreamCaps = map[string]bool{
|
|||||||
"server-time": true,
|
"server-time": true,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type registrationError string
|
||||||
|
|
||||||
|
func (err registrationError) Error() string {
|
||||||
|
return fmt.Sprintf("registration error: %v", string(err))
|
||||||
|
}
|
||||||
|
|
||||||
type upstreamChannel struct {
|
type upstreamChannel struct {
|
||||||
Name string
|
Name string
|
||||||
conn *upstreamConn
|
conn *upstreamConn
|
||||||
@ -1357,7 +1363,8 @@ func (uc *upstreamConn) handleMessage(msg *irc.Message) error {
|
|||||||
return fmt.Errorf("fatal server error: %v", text)
|
return fmt.Errorf("fatal server error: %v", text)
|
||||||
case irc.ERR_PASSWDMISMATCH, irc.ERR_ERRONEUSNICKNAME, irc.ERR_NICKNAMEINUSE, irc.ERR_NICKCOLLISION, irc.ERR_UNAVAILRESOURCE, irc.ERR_NOPERMFORHOST, irc.ERR_YOUREBANNEDCREEP:
|
case irc.ERR_PASSWDMISMATCH, irc.ERR_ERRONEUSNICKNAME, irc.ERR_NICKNAMEINUSE, irc.ERR_NICKCOLLISION, irc.ERR_UNAVAILRESOURCE, irc.ERR_NOPERMFORHOST, irc.ERR_YOUREBANNEDCREEP:
|
||||||
if !uc.registered {
|
if !uc.registered {
|
||||||
return fmt.Errorf("registration failed: %v", msg.Params[len(msg.Params)-1])
|
text := msg.Params[len(msg.Params)-1]
|
||||||
|
return registrationError(text)
|
||||||
}
|
}
|
||||||
fallthrough
|
fallthrough
|
||||||
default:
|
default:
|
||||||
@ -1526,8 +1533,12 @@ func (uc *upstreamConn) runUntilRegistered() error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if err := uc.handleMessage(msg); err != nil {
|
if err := uc.handleMessage(msg); err != nil {
|
||||||
msg.Tags = nil // prevent message tags from cluttering logs
|
if _, ok := err.(registrationError); ok {
|
||||||
return fmt.Errorf("failed to handle message %q: %v", msg, err)
|
return err
|
||||||
|
} else {
|
||||||
|
msg.Tags = nil // prevent message tags from cluttering logs
|
||||||
|
return fmt.Errorf("failed to handle message %q: %v", msg, err)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
8
user.go
8
user.go
@ -140,8 +140,12 @@ func (net *network) run() {
|
|||||||
|
|
||||||
uc.register()
|
uc.register()
|
||||||
if err := uc.runUntilRegistered(); err != nil {
|
if err := uc.runUntilRegistered(); err != nil {
|
||||||
uc.logger.Printf("failed to register: %v", err)
|
text := err.Error()
|
||||||
net.user.events <- eventUpstreamConnectionError{net, fmt.Errorf("failed to register: %v", err)}
|
if regErr, ok := err.(registrationError); ok {
|
||||||
|
text = string(regErr)
|
||||||
|
}
|
||||||
|
uc.logger.Printf("failed to register: %v", text)
|
||||||
|
net.user.events <- eventUpstreamConnectionError{net, fmt.Errorf("failed to register: %v", text)}
|
||||||
uc.Close()
|
uc.Close()
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user