delorean
/
speedboat
1
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Suggestions after code-review #1

New Issue
Closed
opened 2024-08-05 20:27:09 -04:00 by acidvegas · 1 comment
acidvegas commented 2024-08-05 20:27:09 -04:00
Copy Link
  1. Ensure we only follow 1-3 redirects to not fall for tar-pit traps.
  2. .find in rust is case-sensitive. Uppercase HTML circumvents this.
  3. Title buffer limit of 1024 to prevent <title> bomb attacks.
  4. Randomized user agnets that are legit
  5. Potential memory issue storing entire body in a variable. <body> bomb attack.
  6. Async all hashing & parsing
1. Ensure we only follow 1-3 redirects to not fall for tar-pit traps. 2. `.find` in rust is case-sensitive. Uppercase HTML circumvents this. 3. Title buffer limit of 1024 to prevent `<title>` bomb attacks. 4. Randomized user agnets that are legit 5. Potential memory issue storing entire body in a variable. `<body>` bomb attack. 7. Async all hashing & parsing
delorean commented 2024-08-11 13:33:29 -04:00
Owner
Copy Link

🤝

🤝
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: delorean/speedboat#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?