From e4840b4d75ff4dc79083955ebd9dfbdd7dd7ea8a Mon Sep 17 00:00:00 2001 From: Reto Date: Tue, 12 Apr 2022 02:47:51 +0200 Subject: [PATCH] Plugins: include pre-releases in compatibility lookup (#4506) Semver doesn't treat pre-release versions as upgrades, meaning >4.3.0 isn't satisfied by 4.3.1-rc.1. For the purpose of TL plugins however, we are only interested in the semantic version and expect that rc's adhere to the compatibility promise. --- src/plugins/packages/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/packages/index.js b/src/plugins/packages/index.js index 6db96280..a3d99022 100644 --- a/src/plugins/packages/index.js +++ b/src/plugins/packages/index.js @@ -109,7 +109,9 @@ function loadPackage(packageName) { if ( packageInfo.thelounge.supports && - !semver.satisfies(Helper.getVersionNumber(), packageInfo.thelounge.supports) + !semver.satisfies(Helper.getVersionNumber(), packageInfo.thelounge.supports, { + includePrerelease: true, // our pre-releases should respect the semver guarantees + }) ) { throw `v${packageInfo.version} does not support this version of The Lounge. Supports: ${packageInfo.thelounge.supports}`; }