From bc2a37913f7fdd6ae9635763f3122e24251d8e6d Mon Sep 17 00:00:00 2001 From: Alistair McKinlay Date: Wed, 16 Aug 2017 09:01:09 +0100 Subject: [PATCH] Fix issue with falsey user options getting overridden by truthy defaults --- client/js/options.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/client/js/options.js b/client/js/options.js index 4e0d83a6..20f94289 100644 --- a/client/js/options.js +++ b/client/js/options.js @@ -25,14 +25,16 @@ const options = { thumbnails: true, userStyles: userStyles.text(), }; -const userOptions = JSON.parse(storage.get("settings")) || {}; +let userOptions = JSON.parse(storage.get("settings")) || {}; for (const key in options) { - if (userOptions[key]) { + if (userOptions[key] !== undefined) { options[key] = userOptions[key]; } } +userOptions = null; + module.exports = options; module.exports.shouldOpenMessagePreview = function(type) {