From 7a3008aec6f17950668b3e9336c6891c114ab150 Mon Sep 17 00:00:00 2001
From: Pavel Djundik <github@xpaw.me>
Date: Mon, 11 Jun 2018 14:29:57 +0300
Subject: [PATCH] Synchronize number of highlighted messages to client

Also fixes #1791
---
 client/js/lounge.js             |  1 +
 client/js/socket-events/msg.js  | 12 ++++++++----
 client/js/socket-events/open.js |  1 +
 client/views/chan.tpl           |  4 ++--
 src/models/chan.js              | 33 +++++++++++++++++----------------
 5 files changed, 29 insertions(+), 22 deletions(-)

diff --git a/client/js/lounge.js b/client/js/lounge.js
index 7283728f..c0facbd6 100644
--- a/client/js/lounge.js
+++ b/client/js/lounge.js
@@ -188,6 +188,7 @@ $(function() {
 			self.addClass("active")
 				.attr("aria-selected", true)
 				.find(".badge")
+				.attr("data-highlight", 0)
 				.removeClass("highlight")
 				.empty();
 
diff --git a/client/js/socket-events/msg.js b/client/js/socket-events/msg.js
index f96e139d..8fc68462 100644
--- a/client/js/socket-events/msg.js
+++ b/client/js/socket-events/msg.js
@@ -129,7 +129,9 @@ function processReceivedMessage(data) {
 }
 
 function notifyMessage(targetId, channel, msg) {
-	const unread = msg.unread;
+	const serverUnread = msg.unread;
+	const serverHighlight = msg.highlight;
+
 	msg = msg.msg;
 
 	if (msg.self) {
@@ -205,13 +207,15 @@ function notifyMessage(targetId, channel, msg) {
 		}
 	}
 
-	if (!unread || button.hasClass("active")) {
+	if (!serverUnread || button.hasClass("active")) {
 		return;
 	}
 
-	const badge = button.find(".badge").html(helpers_roundBadgeNumber(unread));
+	const badge = button.find(".badge").html(helpers_roundBadgeNumber(serverUnread));
 
 	if (msg.highlight) {
-		badge.addClass("highlight");
+		badge
+			.attr("data-highlight", serverHighlight)
+			.addClass("highlight");
 	}
 }
diff --git a/client/js/socket-events/open.js b/client/js/socket-events/open.js
index 0fd956b1..07368158 100644
--- a/client/js/socket-events/open.js
+++ b/client/js/socket-events/open.js
@@ -18,6 +18,7 @@ socket.on("open", function(id) {
 
 	// Clear the unread badge
 	$("#sidebar").find(".chan[data-id='" + id + "'] .badge")
+		.attr("data-highlight", 0)
 		.removeClass("highlight")
 		.empty();
 
diff --git a/client/views/chan.tpl b/client/views/chan.tpl
index 93bc5712..d9227d45 100644
--- a/client/views/chan.tpl
+++ b/client/views/chan.tpl
@@ -20,7 +20,7 @@
 			<span class="not-connected-tooltip tooltipped tooltipped-w" aria-label="Disconnected">
 				<span class="not-connected-icon"></span>
 			</span>
-			<span class="badge{{#if highlight}} highlight{{/if}}">{{#if unread}}{{roundBadgeNumber unread}}{{/if}}</span>
+			<span class="badge{{#if highlight}} highlight{{/if}}" data-highlight="{{highlight}}">{{#if unread}}{{roundBadgeNumber unread}}{{/if}}</span>
 		</div>
 		<span class="add-channel-tooltip tooltipped tooltipped-w tooltipped-no-touch" aria-label="Join a channel…" data-alt-label="Cancel">
 			<button class="add-channel" aria-label="Join a channel…" aria-controls="join-channel-{{id}}"></button>
@@ -28,7 +28,7 @@
 	{{/equal}}
 	{{#notEqual type "lobby"}}
 		<span class="name" title="{{name}}">{{name}}</span>
-		<span class="badge{{#if highlight}} highlight{{/if}}">{{#if unread}}{{roundBadgeNumber unread}}{{/if}}</span>
+		<span class="badge{{#if highlight}} highlight{{/if}}" data-highlight="{{highlight}}">{{#if unread}}{{roundBadgeNumber unread}}{{/if}}</span>
 		<span class="close-tooltip tooltipped tooltipped-w" aria-label="Leave">
 			<button class="close" aria-label="Leave"></button>
 		</span>
diff --git a/src/models/chan.js b/src/models/chan.js
index 45f1661e..3cd7e99b 100644
--- a/src/models/chan.js
+++ b/src/models/chan.js
@@ -48,8 +48,23 @@ Chan.prototype.pushMessage = function(client, msg, increasesUnread) {
 	// If this channel is open in any of the clients, do not increase unread counter
 	const isOpen = _.find(client.attachedClients, {openChannel: chan}) !== undefined;
 
-	if ((increasesUnread || msg.highlight) && !isOpen) {
-		obj.unread = ++this.unread;
+	if (msg.self) {
+		// reset counters/markers when receiving self-/echo-message
+		this.unread = 0;
+		this.firstUnread = 0;
+		this.highlight = 0;
+	} else if (!isOpen) {
+		if (!this.firstUnread) {
+			this.firstUnread = msg.id;
+		}
+
+		if (increasesUnread || msg.highlight) {
+			obj.unread = ++this.unread;
+		}
+
+		if (msg.highlight) {
+			obj.highlight = ++this.highlight;
+		}
 	}
 
 	client.emit("msg", obj);
@@ -71,20 +86,6 @@ Chan.prototype.pushMessage = function(client, msg, increasesUnread) {
 			this.dereferencePreviews(deleted);
 		}
 	}
-
-	if (msg.self) {
-		// reset counters/markers when receiving self-/echo-message
-		this.firstUnread = 0;
-		this.highlight = 0;
-	} else if (!isOpen) {
-		if (!this.firstUnread) {
-			this.firstUnread = msg.id;
-		}
-
-		if (msg.highlight) {
-			this.highlight++;
-		}
-	}
 };
 
 Chan.prototype.dereferencePreviews = function(messages) {