From 8fa852669806cdf330ce21789a3c99ec5b11813e Mon Sep 17 00:00:00 2001 From: Pavel Djundik Date: Tue, 4 Sep 2018 12:08:30 +0300 Subject: [PATCH] Only emit upload url to the client that uploaded the file Fixes #2747 --- src/plugins/uploader.js | 4 ++-- src/server.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/uploader.js b/src/plugins/uploader.js index 7ef76708..9aa1947a 100644 --- a/src/plugins/uploader.js +++ b/src/plugins/uploader.js @@ -29,7 +29,7 @@ const whitelist = [ ]; class Uploader { - constructor(client, socket) { + constructor(socket) { const uploader = new SocketIOFileUploadServer(); const folder = path.join(Helper.getFileUploadPath(), ".tmp"); @@ -46,7 +46,7 @@ class Uploader { const randomFileName = randomName; const slug = data.file.base; const url = `uploads/${randomFileName}/${slug}`; - client.emit("upload:success", url); + socket.emit("upload:success", url); }); }); diff --git a/src/server.js b/src/server.js index 97bdb051..efbf50c0 100644 --- a/src/server.js +++ b/src/server.js @@ -290,7 +290,7 @@ function initializeClient(socket, client, token, lastMessage) { client.clientAttach(socket.id, token); if (Helper.config.fileUpload.enable) { - new Uploader(client, socket); + new Uploader(socket); } socket.on("disconnect", function() {