supernets/hardlounge
supernets/hardlounge
4
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

test/storage: use helper for url creation

Browse Source 
We keep repeating ourselves, let's move that into a helper instead.
In order to get a sane host, we fix the listener to 127.0.0.1
else we get the unspecified :: ipv6 addr (on suitable hosts),
which isn't useful.
This commit is contained in:
Reto Brunner 2023-06-25 19:29:50 +02:00
parent c6b1913b91
commit 79fae26f39
1 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/plugins/storage.ts
View File

@ -1,4 +1,4 @@
/* eslint-disable @typescript-eslint/restrict-plus-operands */ /* eslint-disable @typescript-eslint/restrict-template-expressions */
import fs from "fs"; import fs from "fs";
import path from "path"; import path from "path";
import crypto from "crypto"; import crypto from "crypto";
@ -42,10 +42,12 @@ describe("Image storage", function () {
this.app.get("/logo.svg", function (req, res) { this.app.get("/logo.svg", function (req, res) {
res.sendFile(testSvgPath); res.sendFile(testSvgPath);
}); });
this.connection = this.app.listen(0, () => { this.connection = this.app.listen(0, "127.0.0.1", () => {
this.port = this.connection.address().port; this.port = this.connection.address().port;
this.host = this.connection.address().address;
done(); done();
}); });
this._makeUrl = (_path: string): string => `http://${this.host}:${this.port}/${_path}`;
}); });
after(function (done) { after(function (done) {
@ -71,64 +73,60 @@ describe("Image storage", function () {
}); });
it("should store the thumbnail", function (done) { it("should store the thumbnail", function (done) {
const port = this.port; const thumb_url = this._makeUrl("thumb");
const message = this.irc.createMessage({ const message = this.irc.createMessage({
text: "http://localhost:" + port + "/thumb", text: thumb_url,
}); });
link(this.irc, this.network.channels[0], message, message.text); link(this.irc, this.network.channels[0], message, message.text);
const real_test_img_url = this._makeUrl("real-test-image.png");
this.app.get("/thumb", function (req, res) { this.app.get("/thumb", function (req, res) {
res.send( res.send(
"<title>Google</title><meta property='og:image' content='http://localhost:" + `<title>Google</title><meta property='og:image' content='${real_test_img_url}'>`
port +
"/real-test-image.png'>"
); );
}); });
this.irc.once("msg:preview", function (data) { this.irc.once("msg:preview", function (data) {
expect(data.preview.head).to.equal("Google"); expect(data.preview.head).to.equal("Google");
expect(data.preview.link).to.equal("http://localhost:" + port + "/thumb"); expect(data.preview.link).to.equal(thumb_url);
expect(data.preview.thumb).to.equal(correctImageURL); expect(data.preview.thumb).to.equal(correctImageURL);
done(); done();
}); });
}); });
it("should store the image", function (done) { it("should store the image", function (done) {
const port = this.port; const real_test_img_url = this._makeUrl("real-test-image.png");
const message = this.irc.createMessage({ const message = this.irc.createMessage({
text: "http://localhost:" + port + "/real-test-image.png", text: real_test_img_url,
}); });
link(this.irc, this.network.channels[0], message, message.text); link(this.irc, this.network.channels[0], message, message.text);
this.irc.once("msg:preview", function (data) { this.irc.once("msg:preview", function (data) {
expect(data.preview.type).to.equal("image"); expect(data.preview.type).to.equal("image");
expect(data.preview.link).to.equal("http://localhost:" + port + "/real-test-image.png"); expect(data.preview.link).to.equal(real_test_img_url);
expect(data.preview.thumb).to.equal(correctImageURL); expect(data.preview.thumb).to.equal(correctImageURL);
done(); done();
}); });
}); });
it("should lookup correct extension type", function (done) { it("should lookup correct extension type", function (done) {
const port = this.port; const msg_url = this._makeUrl("svg-preview");
const message = this.irc.createMessage({ const message = this.irc.createMessage({
text: "http://localhost:" + port + "/svg-preview", text: msg_url,
}); });
const logo_url = this._makeUrl("logo.svg");
this.app.get("/svg-preview", function (req: Request, res: Response) { this.app.get("/svg-preview", function (req: Request, res: Response) {
res.send( res.send(`<title>test title</title><meta property='og:image' content='${logo_url}'>`);
"<title>test title</title><meta property='og:image' content='http://localhost:" +
port +
"/logo.svg'>"
);
}); });
link(this.irc, this.network.channels[0], message, message.text); link(this.irc, this.network.channels[0], message, message.text);
this.irc.once("msg:preview", function (data) { this.irc.once("msg:preview", function (data) {
expect(data.preview.type).to.equal("link"); expect(data.preview.type).to.equal("link");
expect(data.preview.link).to.equal("http://localhost:" + port + "/svg-preview"); expect(data.preview.link).to.equal(msg_url);
expect(data.preview.thumb).to.equal(correctSvgURL); expect(data.preview.thumb).to.equal(correctSvgURL);
done(); done();
}); });