From a403dac8ef6986e26868380548e4b989b97426f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Astori?= Date: Tue, 20 Jun 2017 01:17:11 -0400 Subject: [PATCH 1/2] Build in production environment on script testing PRs --- scripts/run-pr.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/run-pr.sh b/scripts/run-pr.sh index e8e65c5d..a83c6dd1 100755 --- a/scripts/run-pr.sh +++ b/scripts/run-pr.sh @@ -10,6 +10,6 @@ fi git fetch https://github.com/thelounge/lounge.git refs/pull/${1}/head git checkout FETCH_HEAD npm install -npm run build +NODE_ENV=production npm run build npm test || true npm start From 211d2e54602862b45d6a2ff2db4f60e67bcf179f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Astori?= Date: Tue, 20 Jun 2017 01:18:30 -0400 Subject: [PATCH 2/2] Always rebase with master when running PRs to make sure latest code is being tested --- scripts/run-pr.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/run-pr.sh b/scripts/run-pr.sh index a83c6dd1..de020c75 100755 --- a/scripts/run-pr.sh +++ b/scripts/run-pr.sh @@ -9,6 +9,7 @@ fi git fetch https://github.com/thelounge/lounge.git refs/pull/${1}/head git checkout FETCH_HEAD +git rebase master npm install NODE_ENV=production npm run build npm test || true