From 43a8604b3214be5d8aabaa3477649b88d8f4d2cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Astori?= <jeremie@astori.fr>
Date: Sun, 13 Aug 2017 15:09:32 -0400
Subject: [PATCH] Add some human-friendliness to the condensed status messages

---
 client/js/condensed.js | 56 +++++++++++++++++++++++++++---------------
 client/js/constants.js |  6 ++---
 2 files changed, 39 insertions(+), 23 deletions(-)

diff --git a/client/js/condensed.js b/client/js/condensed.js
index 8c994742..a7119d1f 100644
--- a/client/js/condensed.js
+++ b/client/js/condensed.js
@@ -8,32 +8,48 @@ module.exports = {
 };
 
 function updateText(condensed, addedTypes) {
-	var obj = {};
+	const obj = {};
 
-	for (var i in constants.condensedTypes) {
-		var msgType = constants.condensedTypes[i];
-		obj[msgType] = condensed.data(msgType) || 0;
-	}
+	constants.condensedTypes.forEach((type) => {
+		obj[type] = condensed.data(type) || 0;
+	});
 
-	for (var k in addedTypes) {
-		var added = addedTypes[k];
-		obj[added]++;
-		condensed.data(added, obj[added]);
-	}
+	addedTypes.forEach((type) => {
+		obj[type]++;
+		condensed.data(type, obj[type]);
+	});
 
-	var text = "";
-
-	for (var j in constants.condensedTypes) {
-		var messageType = constants.condensedTypes[j];
-		if (obj[messageType]) {
-			text += text === "" ? "" : ", ";
-			text += obj[messageType] + " " + messageType;
-			if (messageType === "nick" || messageType === "mode") {
-				text += " change";
+	const strings = [];
+	constants.condensedTypes.forEach((type) => {
+		if (obj[type]) {
+			switch (type) {
+			case "join":
+				strings.push(obj[type] + (obj[type] > 1 ? " users have joined the channel" : " user has joined the channel"));
+				break;
+			case "part":
+				strings.push(obj[type] + (obj[type] > 1 ? " users have left the channel" : " user has left the channel"));
+				break;
+			case "quit":
+				strings.push(obj[type] + (obj[type] > 1 ? " users have quit" : " user has quit"));
+				break;
+			case "nick":
+				strings.push(obj[type] + (obj[type] > 1 ? " users have changed nick" : " user has changed nick"));
+				break;
+			case "kick":
+				strings.push(obj[type] + (obj[type] > 1 ? " users were kicked" : " user was kicked"));
+				break;
+			case "mode":
+				strings.push(obj[type] + (obj[type] > 1 ? " modes were set" : " mode was set"));
+				break;
 			}
-			text += obj[messageType] > 1 ? "s" : "";
 		}
+	});
+
+	let text = strings.pop();
+	if (strings.length) {
+		text = strings.join(", ") + ", and " + text;
 	}
+
 	condensed.find(".condensed-text")
 		.html(text + templates.msg_condensed_toggle());
 }
diff --git a/client/js/constants.js b/client/js/constants.js
index 0cfb2092..878f0276 100644
--- a/client/js/constants.js
+++ b/client/js/constants.js
@@ -75,11 +75,11 @@ const actionTypes = [
 
 const condensedTypes = [
 	"join",
-	"kick",
-	"mode",
-	"nick",
 	"part",
 	"quit",
+	"nick",
+	"kick",
+	"mode",
 ];
 
 const timeFormats = {