From f7fbf2ea727e9641fea53650442f459f5497139e Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Thu, 23 Feb 2023 13:27:25 +0100 Subject: [PATCH] identd: use UNKNOWN for OS name Some servers like snircd reject OTHER [1], because OTHER can be used when the ident string is not stable (e.g. is an audit token that changes each time the ident is queried). [1]: https://github.com/quakenet/snircd/blob/17c92003d376c70db674821e92f2880ba1587132/ircd/s_auth.c#L559 --- identd/identd.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/identd/identd.go b/identd/identd.go index 9a3c086..3aabf30 100644 --- a/identd/identd.go +++ b/identd/identd.go @@ -129,7 +129,10 @@ func (s *Identd) handle(c net.Conn) { break } - fmt.Fprintf(c, "%s : USERID : OTHER : %s\r\n", l, ident) + // The "OTHER" operating system may be rejected by IRC servers, because + // it may be used when the ident string isn't stable. Use "UNKNOWN" + // from RFC 1340 instead. + fmt.Fprintf(c, "%s : USERID : UNKNOWN : %s\r\n", l, ident) } }