From 8559141b30bfa9acdad4c2385b712b5ee51e1794 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonardo=20Hern=C3=A1ndez=20Hern=C3=A1ndez?= Date: Mon, 3 Oct 2022 23:28:58 -0500 Subject: [PATCH] avoid usage of goto Based on this suggestion: https://github.com/guyuming76/dwl/commit/bc72af6e2430cfb8db2f5fa1b9800c86f445b6d6#commitcomment-85592855 --- dwl.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/dwl.c b/dwl.c index b4fa1ef..5f9cbcd 100644 --- a/dwl.c +++ b/dwl.c @@ -2388,14 +2388,12 @@ unmapnotify(struct wl_listener *listener, void *data) if (c->mon) c->mon->un_map = 1; - if (client_is_unmanaged(c)) - goto end; + if (!client_is_unmanaged(c)) { + wl_list_remove(&c->link); + setmon(c, NULL, 0); + wl_list_remove(&c->flink); + } - wl_list_remove(&c->link); - setmon(c, NULL, 0); - wl_list_remove(&c->flink); - -end: wl_list_remove(&c->commit.link); wlr_scene_node_destroy(c->scene); printstatus();