From 4e57dbd9223c647ece506f5f1fc1465802c13c85 Mon Sep 17 00:00:00 2001 From: "Devin J. Pohly" Date: Thu, 30 Jul 2020 22:46:45 -0500 Subject: [PATCH] attach_render and commit are all that's needed attach_render tells the output that a "new" buffer has been prepared (even if we haven't changed it). We need to call that and then commit it to keep the render loop going. Software cursors will freeze momentarily during layout updates, but I suspect that this is not as easily fixed as it sounds. You can force software cursors by running: WLR_NO_HARDWARE_CURSORS=1 ./dwl --- dwl.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/dwl.c b/dwl.c index e6fa206..3cacba3 100644 --- a/dwl.c +++ b/dwl.c @@ -1256,27 +1256,27 @@ rendermon(struct wl_listener *listener, void *data) if (!wlr_output_attach_render(m->wlr_output, NULL)) return; - /* Begin the renderer (calls glViewport and some other GL sanity checks) */ - wlr_renderer_begin(drw, m->wlr_output->width, m->wlr_output->height); - if (render) { + /* Begin the renderer (calls glViewport and some other GL sanity checks) */ + wlr_renderer_begin(drw, m->wlr_output->width, m->wlr_output->height); wlr_renderer_clear(drw, rootcolor); renderclients(m, &now); renderindependents(output, &now); + + /* Hardware cursors are rendered by the GPU on a separate plane, and can be + * moved around without re-rendering what's beneath them - which is more + * efficient. However, not all hardware supports hardware cursors. For this + * reason, wlroots provides a software fallback, which we ask it to render + * here. wlr_cursor handles configuring hardware vs software cursors for you, + * and this function is a no-op when hardware cursors are in use. */ + wlr_output_render_software_cursors(m->wlr_output, NULL); + + /* Conclude rendering and swap the buffers, showing the final frame + * on-screen. */ + wlr_renderer_end(drw); } - /* Hardware cursors are rendered by the GPU on a separate plane, and can be - * moved around without re-rendering what's beneath them - which is more - * efficient. However, not all hardware supports hardware cursors. For this - * reason, wlroots provides a software fallback, which we ask it to render - * here. wlr_cursor handles configuring hardware vs software cursors for you, - * and this function is a no-op when hardware cursors are in use. */ - wlr_output_render_software_cursors(m->wlr_output, NULL); - - /* Conclude rendering and swap the buffers, showing the final frame - * on-screen. */ - wlr_renderer_end(drw); wlr_output_commit(m->wlr_output); }