From c6204be8e1a793f18e0b413af587ac945b3aa07d Mon Sep 17 00:00:00 2001 From: acidvegas Date: Sat, 23 Mar 2024 15:31:15 -0400 Subject: [PATCH] Added more comments and thoughts --- ingestors/ingest_zone.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ingestors/ingest_zone.py b/ingestors/ingest_zone.py index 3cd1243..a9ea4b9 100644 --- a/ingestors/ingest_zone.py +++ b/ingestors/ingest_zone.py @@ -85,7 +85,7 @@ async def process_data(file_path: str): # Skip comments but detect AXFR transfers to change the source) if line.startswith(';'): - if 'DiG' in line and 'AXFR' in line: + if 'DiG' in line and 'AXFR' in line: # Do we need to worry about case sensitivity? How can we store the nameserver aswell? source = 'axfr' continue @@ -201,4 +201,5 @@ Input: Notes: How do we want to handle hashed NSEC3 records? Do we ignest them as they are, or crack the NSEC3 hashes first and ingest? + Can an AXFR transfer return data out of order? If so, how do we handle that? '''